report: use uv_pid_t instead of custom PID_TYPE

PR-URL: #25597 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
nodejs · Jan 24, 2019 · c598d98 · c598d98
1 parent 213eddd
commit c598d98
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/node_report.cc b/src/node_report.cc
@@ -107,9 +107,8 @@ std::string TriggerNodeReport(Isolate* isolate,
 
   // Obtain the current time and the pid (platform dependent)
   TIME_TYPE tm_struct;
-  PID_TYPE pid;
   LocalTime(&tm_struct);
-  pid = uv_os_getpid();
+  uv_pid_t pid = uv_os_getpid();
   // Determine the required report filename. In order of priority:
   //   1) supplied on API 2) configured on startup 3) default generated
   if (!name.empty()) {
@@ -224,7 +223,7 @@ static void WriteNodeReport(Isolate* isolate,
                             Local<String> stackstr,
                             TIME_TYPE* tm_struct) {
   std::ostringstream buf;
-  PID_TYPE pid = uv_os_getpid();
+  uv_pid_t pid = uv_os_getpid();
 
   // Save formatting for output stream.
   std::ios old_state(nullptr);

diff --git a/src/node_report.h b/src/node_report.h
@@ -32,11 +32,9 @@ namespace report {
 
 #ifdef _WIN32
 typedef SYSTEMTIME TIME_TYPE;
-typedef DWORD PID_TYPE;
 #define PATHSEP "\\"
 #else  // UNIX, OSX
 typedef struct tm TIME_TYPE;
-typedef pid_t PID_TYPE;
 #define PATHSEP "/"
 #endif