-
Notifications
You must be signed in to change notification settings - Fork 29.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stream: emit finish when using writev and cork
In Writable, 'finish' was not emitted when using writev() and cork() in the event of an Error during the write. This commit makes it consistent with the write() path, which emits 'finish'. Fixes: #11121
- Loading branch information
Showing
2 changed files
with
60 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
const assert = require('assert'); | ||
const stream = require('stream'); | ||
|
||
// ensure consistency between the finish event when using cork() | ||
// and writev and when not using them | ||
|
||
{ | ||
const writable = new stream.Writable(); | ||
|
||
writable._write = (chunks, encoding, cb) => { | ||
cb(new Error('write test error')); | ||
}; | ||
|
||
writable.on('finish', common.mustCall()); | ||
|
||
writable.on('prefinish', common.mustCall()); | ||
|
||
writable.on('error', common.mustCall((er) => { | ||
assert.strictEqual(er.message, 'write test error'); | ||
})); | ||
|
||
writable.end('test'); | ||
} | ||
|
||
{ | ||
const writable = new stream.Writable(); | ||
|
||
writable._write = (chunks, encoding, cb) => { | ||
cb(new Error('write test error')); | ||
}; | ||
|
||
writable._writev = (chunks, cb) => { | ||
cb(new Error('writev test error')); | ||
}; | ||
|
||
writable.on('finish', common.mustCall()); | ||
|
||
writable.on('prefinish', common.mustCall()); | ||
|
||
writable.on('error', common.mustCall((er) => { | ||
assert.strictEqual(er.message, 'writev test error'); | ||
})); | ||
|
||
writable.cork(); | ||
writable.write('test'); | ||
|
||
setImmediate(function() { | ||
writable.end('test'); | ||
}); | ||
} |