Skip to content

Commit

Permalink
test: performance - remove Popen(shell=True) on Windows
Browse files Browse the repository at this point in the history
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2
  • Loading branch information
refack committed Mar 30, 2017
1 parent 61ebfa8 commit c236248
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,6 @@ def RunProcess(context, timeout, args, **rest):
pty_out = rest.pop('pty_out')

process = subprocess.Popen(
shell = utils.IsWindows(),
args = popen_args,
**rest
)
Expand Down

0 comments on commit c236248

Please sign in to comment.