src: ignore SIGXFSZ, don't terminate (ulimit -f)

Ignore SIGXFSZ signals so that exceeding RLIMIT_FSIZE makes the offending system call fail with EFBIG instead of terminating the process. PR-URL: #27798 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · May 23, 2019 · c0cf173 · c0cf173
1 parent 3b6424f
commit c0cf173
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/src/node.cc b/src/node.cc
@@ -491,7 +491,7 @@ inline void PlatformInit() {
   for (unsigned nr = 1; nr < kMaxSignal; nr += 1) {
     if (nr == SIGKILL || nr == SIGSTOP)
       continue;
-    act.sa_handler = (nr == SIGPIPE) ? SIG_IGN : SIG_DFL;
+    act.sa_handler = (nr == SIGPIPE || nr == SIGXFSZ) ? SIG_IGN : SIG_DFL;
     CHECK_EQ(0, sigaction(nr, &act, nullptr));
   }
 #endif  // !NODE_SHARED_MODE

diff --git a/test/parallel/test-fs-write-sigxfsz.js b/test/parallel/test-fs-write-sigxfsz.js
@@ -0,0 +1,32 @@
+// Check that exceeding RLIMIT_FSIZE fails with EFBIG
+// rather than terminating the process with SIGXFSZ.
+'use strict';
+const common = require('../common');
+const tmpdir = require('../common/tmpdir');
+
+const assert = require('assert');
+const child_process = require('child_process');
+const fs = require('fs');
+const path = require('path');
+
+if (common.isWindows)
+  common.skip('no RLIMIT_FSIZE on Windows');
+
+if (process.config.variables.node_shared)
+  common.skip('SIGXFSZ signal handler not installed in shared library mode');
+
+if (process.argv[2] === 'child') {
+  const filename = path.join(tmpdir.path, 'efbig.txt');
+  tmpdir.refresh();
+  fs.writeFileSync(filename, '.'.repeat(1 << 16));  // Exceeds RLIMIT_FSIZE.
+} else {
+  const cmd = `ulimit -f 1 && '${process.execPath}' '${__filename}' child`;
+  const result = child_process.spawnSync('/bin/sh', ['-c', cmd]);
+  const haystack = result.stderr.toString();
+  const needle = 'Error: EFBIG: file too large, write';
+  const ok = haystack.includes(needle);
+  if (!ok) console.error(haystack);
+  assert(ok);
+  assert.strictEqual(result.status, 1);
+  assert.strictEqual(result.stdout.toString(), '');
+}