Skip to content

Commit bdbfc0e

Browse files
ryzokukenMylesBorins
authored andcommitted
test: rename test-regress-GH-4015
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19161 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent da44c2c commit bdbfc0e

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

test/sequential/test-regress-GH-4015.js renamed to test/sequential/test-regress-fs-stat_sync.js

+8
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,14 @@
2222
'use strict';
2323
require('../common');
2424
const { fixturesDir } = require('../common/fixtures');
25+
26+
// Check that the calls to Integer::New() and Date::New() succeed and bail out
27+
// if they don't.
28+
// V8 returns an empty handle on stack overflow. Trying to set the empty handle
29+
// as a property on an object results in a NULL pointer dereference in release
30+
// builds and an assert in debug builds.
31+
// https://github.com/nodejs/node-v0.x-archive/issues/4015
32+
2533
const assert = require('assert');
2634
const { exec } = require('child_process');
2735

0 commit comments

Comments
 (0)