Skip to content

Commit

Permalink
lib: move DEP0021 to end of life
Browse files Browse the repository at this point in the history
Server.listenFD() has been runtime deprecated since
Node 0.7.12. This commit moves the deprecation to
end-of-life.

PR-URL: #27127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
  • Loading branch information
cjihrig committed Apr 10, 2019
1 parent 41d5666 commit bd9109c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
7 changes: 5 additions & 2 deletions doc/api/deprecations.md
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,9 @@ The [`Server.connections`][] property is deprecated. Please use the
### DEP0021: Server.listenFD
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/27127
description: End-of-Life.
- version:
- v4.8.6
- v6.12.0
Expand All @@ -493,9 +496,9 @@ changes:
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `Server.listenFD()` method is deprecated. Please use
The `Server.listenFD()` method was deprecated and removed. Please use
[`Server.listen({fd: <number>})`][] instead.

<a id="DEP0022"></a>
Expand Down
6 changes: 0 additions & 6 deletions lib/net.js
Original file line number Diff line number Diff line change
Expand Up @@ -1590,12 +1590,6 @@ Object.defineProperty(Socket.prototype, '_handle', {
set(v) { return this[kHandle] = v; }
});


Server.prototype.listenFD = deprecate(function(fd, type) {
return this.listen({ fd: fd });
}, 'Server.listenFD is deprecated. Use Server.listen({fd: <number>}) instead.',
'DEP0021');

Server.prototype._setupWorker = function(socketList) {
this._usingWorkers = true;
this._workers.push(socketList);
Expand Down

0 comments on commit bd9109c

Please sign in to comment.