src: only open HandleScope when necessary

PR-URL: #26734 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
nodejs · Mar 21, 2019 · bca23f2 · bca23f2
1 parent d812dbb
commit bca23f2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/api/callback.cc b/src/api/callback.cc
@@ -79,7 +79,6 @@ InternalCallbackScope::~InternalCallbackScope() {
 void InternalCallbackScope::Close() {
   if (closed_) return;
   closed_ = true;
-  HandleScope handle_scope(env_->isolate());
 
   if (!env_->can_call_into_js()) return;
   if (failed_ && !env_->is_main_thread() && env_->is_stopping()) {
@@ -117,6 +116,7 @@ void InternalCallbackScope::Close() {
     return;
   }
 
+  HandleScope handle_scope(env_->isolate());
   Local<Object> process = env_->process_object();
 
   if (!env_->can_call_into_js()) return;