Skip to content

Commit

Permalink
benchmark: add url benchmarks
Browse files Browse the repository at this point in the history
Based on the ad-hoc benchmark from nodejs/node-v0.x-archive#8638.
  • Loading branch information
bnoordhuis committed Dec 6, 2014
1 parent 36aeae8 commit b7fc957
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions benchmark/url/url.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
var common = require('../common.js');
var url = require('url');

var bench = common.createBenchmark(main, {
type: 'one two three four five'.split(' '),
n: [25e4]
});

function main(conf) {
var type = conf.type;
var n = conf.n | 0;

var inputs = {
one: 'http://nodejs.org/docs/latest/api/url.html#url_url_format_urlobj',
two: 'http://blog.nodejs.org/',
three: 'https://encrypted.google.com/search?q=url&q=site:npmjs.org&hl=en',
four: 'javascript:alert("node is awesome");',
five: 'some.ran/dom/url.thing?oh=yes#whoo',
};
var input = inputs[type] || '';

bench.start();
for (var i = 0; i < n; i += 1)
url.parse(input);
bench.end(n);
}

1 comment on commit b7fc957

@chrisdickinson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a case for testing a url with auth? Otherwise LGTM.

(I wish there was a way we could tell v8 to make sure not to OSR-inline the url.parse since that could skew the results.)

Please sign in to comment.