Skip to content

Commit

Permalink
test: rename custom encoding tests that cannot be replaced by WPT
Browse files Browse the repository at this point in the history
PR-URL: #25155
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
joyeecheung authored and targos committed Jan 1, 2019
1 parent be42182 commit b45be67
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

// From: https://github.com/w3c/web-platform-tests/blob/d74324b53c/encoding/textdecoder-fatal-streaming.html
// With the twist that we specifically test for Node.js error codes

const common = require('../common');

Expand Down Expand Up @@ -28,6 +29,7 @@ const assert = require('assert');
}
);

// TODO(joyeecheung): remove this when WPT is ported
assert.strictEqual(
new TextDecoder(testCase.encoding).decode(data),
'\uFFFD'
Expand All @@ -40,6 +42,7 @@ const assert = require('assert');
const odd = new Uint8Array([0x00]);
const even = new Uint8Array([0x00, 0x00]);

// TODO(joyeecheung): remove this when WPT is ported
assert.strictEqual(decoder.decode(odd, { stream: true }), '');
assert.strictEqual(decoder.decode(odd), '\u0000');

Expand Down Expand Up @@ -67,6 +70,7 @@ const assert = require('assert');
}
);

// TODO(joyeecheung): remove this when WPT is ported
assert.strictEqual(decoder.decode(even, { stream: true }), '\u0000');
assert.strictEqual(decoder.decode(even), '\u0000');
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Flags: --expose-internals
'use strict';

// This tests internal mapping of the Node.js encoding implementation

require('../common');

const assert = require('assert');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
// Flags: --expose-internals

// This tests interoperability between TextEncoder and TextDecoder with
// Node.js util.inspect and Buffer APIs

'use strict';

const common = require('../common');
Expand Down

0 comments on commit b45be67

Please sign in to comment.