path,win: fix bug in resolve

Fixes: #54025
nodejs · Aug 6, 2024 · b40e78c · b40e78c
1 parent 49a9ba4
commit b40e78c
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 9 deletions.
diff --git a/lib/path.js b/lib/path.js
@@ -263,11 +263,17 @@ const win32 = {
                      !isPathSeparator(StringPrototypeCharCodeAt(path, j))) {
                 j++;
               }
-              if (j === len || j !== last) {
-                // We matched a UNC root
-                device =
-                  `\\\\${firstPart}\\${StringPrototypeSlice(path, last, j)}`;
-                rootEnd = j;
+              if ((j === len || j !== last)) {
+                if (firstPart !== '.') {
+                  // We matched a UNC root
+                  device =
+                    `\\\\${firstPart}\\${StringPrototypeSlice(path, last, j)}`;
+                  rootEnd = j;
+                } else {
+                  // We matched a device root (e.g. \\\\.\\PHYSICALDRIVE0)
+                  device = `\\\\${firstPart}`;
+                  rootEnd = 4;
+                }
               }
             }
           }

diff --git a/src/path.cc b/src/path.cc
@@ -169,10 +169,17 @@ std::string PathResolve(Environment* env,
             while (j < len && !IsPathSeparator(path[j])) {
               j++;
             }
-            if (j == len || j != last) {
-              // We matched a UNC root
-              device = "\\\\" + firstPart + "\\" + path.substr(last, j - last);
-              rootEnd = j;
+            if ((j == len || j != last)) {
+              if (firstPart != ".") {
+                // We matched a UNC root
+                device =
+                    "\\\\" + firstPart + "\\" + path.substr(last, j - last);
+                rootEnd = j;
+              } else {
+                // We matched a device root (e.g. \\\\.\\PHYSICALDRIVE0)
+                device = "\\\\" + firstPart;
+                rootEnd = 4;
+              }
             }
           }
         }

diff --git a/test/cctest/test_path.cc b/test/cctest/test_path.cc
@@ -39,6 +39,8 @@ TEST_F(PathTest, PathResolve) {
   EXPECT_EQ(
       PathResolve(*env, {"C:\\foo\\tmp.3\\", "..\\tmp.3\\cycles\\root.js"}),
       "C:\\foo\\tmp.3\\cycles\\root.js");
+  EXPECT_EQ(PathResolve(*env, {"\\\\.\\PHYSICALDRIVE0"}),
+            "\\\\.\\PHYSICALDRIVE0");
 #else
   EXPECT_EQ(PathResolve(*env, {"/var/lib", "../", "file/"}), "/var/file");
   EXPECT_EQ(PathResolve(*env, {"/var/lib", "/../", "file/"}), "/file");

diff --git a/test/parallel/test-path-resolve.js b/test/parallel/test-path-resolve.js
@@ -33,6 +33,7 @@ const resolveTests = [
      [['c:/', '///some//dir'], 'c:\\some\\dir'],
      [['C:\\foo\\tmp.3\\', '..\\tmp.3\\cycles\\root.js'],
       'C:\\foo\\tmp.3\\cycles\\root.js'],
+     [['\\\\.\\PHYSICALDRIVE0'], '\\\\.\\PHYSICALDRIVE0'],
     ],
   ],
   [ path.posix.resolve,