fixup: simplify

nodejs · Oct 3, 2019 · b2600ca · b2600ca
1 parent 0faf029
commit b2600ca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/internal/streams/duplexpair.js b/lib/internal/streams/duplexpair.js
@@ -20,10 +20,10 @@ class DuplexSocket extends Duplex {
   }
 
   _write(chunk, encoding, callback) {
-    this[kOtherSide].push(chunk);
-    if (!this[kOtherSide].readableLength) {
+    if (chunk.length === 0) {
       process.nextTick(callback);
     } else {
+      this[kOtherSide].push(chunk);
       this[kOtherSide][kCallback] = callback;
     }
   }

diff --git a/test/common/duplexpair.js b/test/common/duplexpair.js
@@ -24,10 +24,10 @@ class DuplexSocket extends Duplex {
   _write(chunk, encoding, callback) {
     assert.notStrictEqual(this[kOtherSide], null);
     assert.strictEqual(this[kOtherSide][kCallback], null);
-    this[kOtherSide].push(chunk);
-    if (!this[kOtherSide].readableLength) {
+    if (chunk.length === 0) {
       process.nextTick(callback);
     } else {
+      this[kOtherSide].push(chunk);
       this[kOtherSide][kCallback] = callback;
     }
   }