repl: fix tab completion of inspector module

Correctly check for the presence of the inspector module before adding it to the builtin libs list. PR-URL: #19505 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Mar 23, 2018 · a6f3e8f · a6f3e8f
1 parent c6c957d
commit a6f3e8f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/internal/modules/cjs/helpers.js b/lib/internal/modules/cjs/helpers.js
@@ -104,7 +104,7 @@ const builtinLibs = [
   'stream', 'string_decoder', 'tls', 'tty', 'url', 'util', 'v8', 'vm', 'zlib'
 ];
 
-if (typeof process.binding('inspector').connect === 'function') {
+if (typeof process.binding('inspector').open === 'function') {
   builtinLibs.push('inspector');
   builtinLibs.sort();
 }

diff --git a/test/parallel/test-module-cjs-helpers.js b/test/parallel/test-module-cjs-helpers.js
@@ -0,0 +1,11 @@
+'use strict';
+// Flags: --expose-internals
+
+require('../common');
+const assert = require('assert');
+const { builtinLibs } = require('internal/modules/cjs/helpers');
+
+const hasInspector = process.config.variables.v8_enable_inspector === 1;
+
+const expectedLibs = hasInspector ? 32 : 31;
+assert.strictEqual(builtinLibs.length, expectedLibs);