Skip to content

Commit

Permalink
test: add logging in case of infinite loop
Browse files Browse the repository at this point in the history
test-inspector-contexts may be entering an infinite loop (or very
long-running loop) in CI, resulting in flakiness. Or maybe not. Add
logging to find out.

PR-URL: #30649
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
Trott authored and addaleax committed Nov 30, 2019
1 parent 3e3ad39 commit a2f440d
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions test/sequential/test-inspector-contexts.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC.');
while (!contextDestroyed)
global.gc();
console.log('Context destroyed.');

assert.strictEqual(contextDestroyed.params.executionContextId, id,
JSON.stringify(contextDestroyed));
Expand Down Expand Up @@ -95,8 +97,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC again.');
while (!contextDestroyed)
global.gc();
console.log('Other context destroyed.');
}

{
Expand All @@ -119,8 +123,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC a third time.');
while (!contextDestroyed)
global.gc();
console.log('Context destroyed once again.');
}

{
Expand All @@ -141,8 +147,10 @@ async function testContextCreatedAndDestroyed() {
JSON.stringify(contextCreated));

// GC is unpredictable...
console.log('Checking/waiting for GC a fourth time.');
while (!contextDestroyed)
global.gc();
console.log('Context destroyed a fourth time.');
}
}

Expand Down

0 comments on commit a2f440d

Please sign in to comment.