buffer: fix missing null/undefined check

The new implementation of Buffer missed the check for null/undefined as the first argument to new Buffer(). Reintroduce the check and add test. Fix: e8734c0 "buffer: implement Uint8Array backed Buffer" Fix: #2194 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
nodejs · Jul 27, 2015 · 9cf36a1 · 9cf36a1
1 parent 4737dcd
commit 9cf36a1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -105,6 +105,10 @@ function fromObject(obj) {
     return b;
   }
 
+  if (obj == null) {
+    throw new TypeError('must start with number, buffer, array or string');
+  }
+
   if (obj instanceof ArrayBuffer) {
     return binding.createFromArrayBuffer(obj);
   }

diff --git a/test/parallel/test-buffer.js b/test/parallel/test-buffer.js
@@ -1179,3 +1179,11 @@ Buffer.poolSize = ps;
 assert.throws(function() {
   Buffer(10).copy();
 });
+
+assert.throws(function() {
+  new Buffer();
+}, /must start with number, buffer, array or string/);
+
+assert.throws(function() {
+  new Buffer(null);
+}, /must start with number, buffer, array or string/);