Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: use relative path in pipePrefix
Modified pipePrefix to use relative path on windows, previously tests failed when the full path was 120+ characters PR-URL: #15988 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
- Loading branch information
971aad1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not passing the blame, It's just that only now I realized this was not part of c34ae48)
Tiny bit of PM for #16364
Strips the last
/
so laterexports.PIPE = pipePrefix + pipeName;
now requires apath.join
971aad1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@refack yikes..
971aad1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path
can always surprise you π€·ββοΈLike I told Rich, I was sure I wrote this, since this is totally something I would do.