src: fix warning for potential snprintf truncation

gcc 8+ recognizes that space has not been left for the pid and that the return value of snprintf() isn't checked. Leave a little space for the pid to prevent `-Wformat-truncation`. PR-URL: #24810 Reviewed-By: Richard Lau <[email protected]>
nodejs · Dec 7, 2018 · 94d02ca · 94d02ca
1 parent c3dda00
commit 94d02ca
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/util.cc b/src/util.cc
@@ -116,7 +116,8 @@ std::string GetHumanReadableProcessName() {
 }
 
 void GetHumanReadableProcessName(char (*name)[1024]) {
-  char title[1024] = "Node.js";
+  // Leave room after title for pid, which can be up to 20 digits for 64 bit.
+  char title[1000] = "Node.js";
   uv_get_process_title(title, sizeof(title));
   snprintf(*name, sizeof(*name), "%s[%d]", title, uv_os_getpid());
 }