quic: fix clang warning

PR-URL: #33963 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Jun 22, 2020 · 8ef86a9 · 8ef86a9
1 parent 680644a
commit 8ef86a9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/quic/node_quic_crypto.cc b/src/quic/node_quic_crypto.cc
@@ -560,7 +560,9 @@ Local<Value> GetALPNProtocol(const QuicSession& session) {
   QuicCryptoContext* ctx = session.crypto_context();
   Environment* env = session.env();
   std::string alpn = ctx->selected_alpn();
-  if (alpn == NGTCP2_ALPN_H3 + 1) {
+  // This supposed to be `NGTCP2_ALPN_H3 + 1`
+  // Details see https://github.com/nodejs/node/issues/33959
+  if (alpn == &NGTCP2_ALPN_H3[1]) {
     return env->quic_alpn_string();
   } else {
     return ToV8Value(