fs: improve error message for invalid flag

Flags on fs.open and others can be passed as strings or int. Previously, if passing anything other than string or int, the error message would only say that flags must be an int. PR-URL: #5590 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Mar 9, 2016 · 8bb60e3 · 8bb60e3
1 parent 3c84752
commit 8bb60e3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/fs.js b/lib/fs.js
@@ -536,8 +536,8 @@ fs.readFileSync = function(path, options) {
 
 // Used by binding.open and friends
 function stringToFlags(flag) {
-  // Only mess with strings
-  if (typeof flag !== 'string') {
+  // Return early if it's a number
+  if (typeof flag === 'number') {
     return flag;
   }