url: call ada::can_parse directly

PR-URL: #47919 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
nodejs · May 18, 2023 · 8b6947f · 8b6947f
1 parent 10b21e5
commit 8b6947f
Showing 1 changed file with 10 additions and 17 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -125,32 +125,25 @@ void BindingData::CanParse(const FunctionCallbackInfo<Value>& args) {
 
   Environment* env = Environment::GetCurrent(args);
   HandleScope handle_scope(env->isolate());
-  Context::Scope context_scope(env->context());
 
   Utf8Value input(env->isolate(), args[0]);
-  ada::result<ada::url_aggregator> base;
-  ada::url_aggregator* base_pointer = nullptr;
+  std::string_view input_view = input.ToStringView();
+
+  bool can_parse{};
   if (args[1]->IsString()) {
-    base = ada::parse<ada::url_aggregator>(
-        Utf8Value(env->isolate(), args[1]).ToString());
-    if (!base) {
-      return args.GetReturnValue().Set(false);
-    }
-    base_pointer = &base.value();
+    Utf8Value base(env->isolate(), args[1]);
+    std::string_view base_view = base.ToStringView();
+    can_parse = ada::can_parse(input_view, &base_view);
+  } else {
+    can_parse = ada::can_parse(input_view);
   }
-  auto out =
-      ada::parse<ada::url_aggregator>(input.ToStringView(), base_pointer);
 
-  args.GetReturnValue().Set(out.has_value());
+  args.GetReturnValue().Set(can_parse);
 }
 
 bool BindingData::FastCanParse(Local<Value> receiver,
                                const FastOneByteString& input) {
-  std::string_view input_view(input.data, input.length);
-
-  auto output = ada::parse<ada::url_aggregator>(input_view);
-
-  return output.has_value();
+  return ada::can_parse(std::string_view(input.data, input.length));
 }
 
 CFunction BindingData::fast_can_parse_(CFunction::Make(FastCanParse));