url: fix off-by-one error with parse()

Fixes: #5393 PR-URL: #5394 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
nodejs · Feb 27, 2016 · 8b16ba3 · 8b16ba3
1 parent 3a331b6
commit 8b16ba3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/url.js b/lib/url.js
@@ -413,7 +413,7 @@ function validateHostname(self, rest, hostname) {
     }
     // Invalid host character
     self.hostname = hostname.slice(0, i);
-    if (i < hostname.length - 1)
+    if (i < hostname.length)
       return '/' + hostname.slice(i) + rest;
     break;
   }

diff --git a/test/parallel/test-url.js b/test/parallel/test-url.js
@@ -851,6 +851,21 @@ var parseTests = {
     pathname: '/:npm/npm',
     path: '/:npm/npm',
     href: 'git+ssh://[email protected]/:npm/npm'
+  },
+
+  'https://*': {
+    protocol: 'https:',
+    slashes: true,
+    auth: null,
+    host: '',
+    port: null,
+    hostname: '',
+    hash: null,
+    search: null,
+    query: null,
+    pathname: '/*',
+    path: '/*',
+    href: 'https:///*'
   }
 
 };