test: improve code in test-fs-open.js

* use const and let instead of var * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok * use assert.ifError PR-URL: #10312 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Italo A. Casas <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
nodejs · Jan 31, 2017 · 8792fb1 · 8792fb1
1 parent f9227fe
commit 8792fb1
Showing 1 changed file with 10 additions and 13 deletions.
diff --git a/test/parallel/test-fs-open.js b/test/parallel/test-fs-open.js
@@ -1,27 +1,24 @@
 'use strict';
 const common = require('../common');
-var assert = require('assert');
-var fs = require('fs');
+const assert = require('assert');
+const fs = require('fs');
+
+let caughtException = false;
 
-var caughtException = false;
 try {
   // should throw ENOENT, not EBADF
   // see https://github.com/joyent/node/pull/1228
   fs.openSync('/path/to/file/that/does/not/exist', 'r');
 } catch (e) {
-  assert.equal(e.code, 'ENOENT');
+  assert.strictEqual(e.code, 'ENOENT');
   caughtException = true;
 }
-assert.ok(caughtException);
+assert.strictEqual(caughtException, true);
 
-fs.open(__filename, 'r', common.mustCall(function(err, fd) {
-  if (err) {
-    throw err;
-  }
+fs.open(__filename, 'r', common.mustCall((err) => {
+  assert.ifError(err);
 }));
 
-fs.open(__filename, 'rs', common.mustCall(function(err, fd) {
-  if (err) {
-    throw err;
-  }
+fs.open(__filename, 'rs', common.mustCall((err) => {
+  assert.ifError(err);
 }));