async_hooks: require parameter in emitBefore

Using asyncId as the default triggerAsyncId is wrong. The triggerAsyncId can actually never be the asyncId. PR-URL: #14050 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
nodejs · Jul 6, 2017 · 84f9261 · 84f9261
1 parent 4e27aa9
commit 84f9261
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/async_hooks.js b/lib/async_hooks.js
@@ -377,7 +377,7 @@ function emitHookFactory(symbol, name) {
 
 // Usage: emitBeforeS(asyncId[, triggerAsyncId]). If triggerAsyncId is omitted
 // then asyncId will be used instead.
-function emitBeforeS(asyncId, triggerAsyncId = asyncId) {
+function emitBeforeS(asyncId, triggerAsyncId) {
   // CHECK(Number.isSafeInteger(asyncId) && asyncId > 0)
   // CHECK(Number.isSafeInteger(triggerAsyncId) && triggerAsyncId > 0)