Skip to content

Commit

Permalink
quic: address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jasnell committed Dec 9, 2023
1 parent 7ca1bfb commit 81a31c6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/dataqueue/queue.cc
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ class DataQueueImpl final : public DataQueue,

void NotifyBackpressure(size_t amount) {
if (idempotent_) return;
for (auto listener : backpressure_listeners_) listener->EntryRead(amount);
for (auto& listener : backpressure_listeners_) listener->EntryRead(amount);
}

bool HasBackpressureListeners() const {
bool HasBackpressureListeners() const noexcept {
return !backpressure_listeners_.empty();
}

Expand Down
2 changes: 1 addition & 1 deletion src/quic/streams.cc
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ BaseObjectPtr<Blob::Reader> Stream::get_reader() {

void Stream::set_final_size(uint64_t final_size) {
DCHECK_IMPLIES(state_->fin_received == 1,
final_size <= stats_.Get<&Stats::final_size>());
final_size <= STAT_GET(Stats, final_size));
state_->fin_received = 1;
STAT_SET(Stats, final_size, final_size);
}
Expand Down

0 comments on commit 81a31c6

Please sign in to comment.