src: fix nullptr dereference for signal during startup

This fixes a test failure when running `test/parallel/test-child-process-spawnsync-kill-signal.js` under load. What would happen is that `SignalExit()` tries to shutdown the tracing agent, which might not have been set up by the point that Node.js receives the signal. PR-URL: #20637 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Aug 16, 2018 · 8076a79 · 8076a79
1 parent 1cb9772
commit 8076a79
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/node.cc b/src/node.cc
@@ -324,7 +324,8 @@ static struct {
   }
 
   void StopTracingAgent() {
-    tracing_agent_->Stop();
+    if (tracing_agent_)
+      tracing_agent_->Stop();
   }
 
   NodePlatform* Platform() {