module: do not use process.exit()

Inside workers, using stdio is always asynchronous, so using `process.exit()` always interrupts sending of messages to the parent thread, including error messages presented over stdio. Do not use `process.exit()` and instead trigger a “real” uncaught exception. PR-URL: #25769 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jan 30, 2019 · 7fa5157 · 7fa5157
1 parent 94ebf3f
commit 7fa5157
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -60,14 +60,12 @@ module.exports = Module;
 let asyncESM;
 let ModuleJob;
 let createDynamicModule;
-let decorateErrorStack;
 
 function lazyLoadESM() {
   asyncESM = require('internal/process/esm_loader');
   ModuleJob = require('internal/modules/esm/module_job');
   createDynamicModule = require(
     'internal/modules/esm/create_dynamic_module');
-  decorateErrorStack = require('internal/util').decorateErrorStack;
 }
 
 const {
@@ -794,9 +792,7 @@ Module.runMain = function() {
       return loader.import(pathToFileURL(process.argv[1]).pathname);
     })
     .catch((e) => {
-      decorateErrorStack(e);
-      console.error(e);
-      process.exit(1);
+      internalBinding('util').triggerFatalException(e);
     });
   } else {
     Module._load(process.argv[1], null, true);

diff --git a/test/parallel/test-worker-esm-missing-main.js b/test/parallel/test-worker-esm-missing-main.js
@@ -0,0 +1,13 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+const { Worker } = require('worker_threads');
+
+const worker = new Worker('./does-not-exist.js', {
+  execArgv: ['--experimental-modules'],
+});
+
+worker.on('error', common.mustCall((err) => {
+  // eslint-disable-next-line node-core/no-unescaped-regexp-dot
+  assert(/Cannot find module .+does-not-exist.js/.test(err.message), err);
+}));