Skip to content

Commit

Permalink
build: avoid compiling with VS v17.10
Browse files Browse the repository at this point in the history
Refs: nodejs/build#3739
PR-URL: #53863
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
  • Loading branch information
huseyinacacak-janea authored and RafaelGSS committed Aug 5, 2024
1 parent f4a7ac5 commit 7c417c6
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,14 @@ goto exit

:msbuild-found

@rem Visual Studio v17.10 has a bug that causes the build to fail.
@rem Check if the version is v17.10 and exit if it is.
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
if %errorlevel% neq 1 (
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
goto exit
)

@rem check if the clang-cl build is requested
if not defined clang_cl goto clang-skip
@rem x64 is hard coded as it is used for both cross and native compilation.
Expand Down

0 comments on commit 7c417c6

Please sign in to comment.