-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: #3940 PR-URL: #4389 Reviewed-By: Ben Noordhuis <[email protected]>
- Loading branch information
Showing
2 changed files
with
56 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
|
||
if (!common.hasCrypto) { | ||
console.log('1..0 # Skipped: missing crypto'); | ||
return; | ||
} | ||
const https = require('https'); | ||
|
||
const fs = require('fs'); | ||
|
||
const options = { | ||
key: fs.readFileSync(common.fixturesDir + '/keys/agent1-key.pem'), | ||
cert: fs.readFileSync(common.fixturesDir + '/keys/agent1-cert.pem') | ||
}; | ||
|
||
const TOTAL = 4; | ||
var waiting = TOTAL; | ||
|
||
const server = https.Server(options, function(req, res) { | ||
if (--waiting === 0) server.close(); | ||
|
||
res.writeHead(200, { | ||
'x-sni': req.socket.servername | ||
}); | ||
res.end('hello world'); | ||
}); | ||
|
||
server.listen(common.PORT, function() { | ||
function expectResponse(id) { | ||
return common.mustCall(function(res) { | ||
res.resume(); | ||
assert.equal(res.headers['x-sni'], 'sni.' + id); | ||
}); | ||
} | ||
|
||
var agent = new https.Agent({ | ||
maxSockets: 1 | ||
}); | ||
for (var j = 0; j < TOTAL; j++) { | ||
https.get({ | ||
agent: agent, | ||
|
||
path: '/', | ||
port: common.PORT, | ||
host: '127.0.0.1', | ||
servername: 'sni.' + j, | ||
rejectUnauthorized: false | ||
}, expectResponse(j)); | ||
} | ||
}); |