errors: make range mandatory in ERR_OUT_OF_RANGE

So far the range argument was allowed to be undefined. This is not used in the codebase anymore and therefore it is best to make it mandatory for the best user experience. PR-URL: #26924 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Apr 4, 2019 · 749aa5f · 749aa5f
1 parent 4e1e7c3
commit 749aa5f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -995,10 +995,10 @@ E('ERR_NO_ICU',
 E('ERR_NO_LONGER_SUPPORTED', '%s is no longer supported', Error);
 E('ERR_OUT_OF_RANGE',
   (str, range, input, replaceDefaultBoolean = false) => {
+    assert(range, 'Missing "range" argument');
     let msg = replaceDefaultBoolean ? str :
       `The value of "${str}" is out of range.`;
-    if (range !== undefined) msg += ` It must be ${range}.`;
-    msg += ` Received ${input}`;
+    msg += ` It must be ${range}. Received ${input}`;
     return msg;
   }, RangeError);
 E('ERR_REQUIRE_ESM', 'Must use import to load ES Module: %s', Error);