Skip to content

Commit

Permalink
os: make EOL configurable and readonly
Browse files Browse the repository at this point in the history
Refs: #14619
  • Loading branch information
XadillaX committed Aug 17, 2017
1 parent cd9f81d commit 6f5087d
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 5 deletions.
18 changes: 13 additions & 5 deletions lib/os.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ function networkInterfaces() {
module.exports = exports = {
arch,
cpus,
EOL: isWindows ? '\r\n' : '\n',
endianness,
freemem: getFreeMem,
homedir: getHomeDirectory,
Expand All @@ -162,8 +161,17 @@ module.exports = exports = {
tmpDir: deprecate(tmpdir, tmpDirDeprecationMsg, 'DEP0022')
};

Object.defineProperty(module.exports, 'constants', {
configurable: false,
enumerable: true,
value: constants
Object.defineProperties(module.exports, {
constants: {
configurable: false,
enumerable: true,
value: constants
},

EOL: {
configurable: true,
enumerable: true,
writable: false,
value: isWindows ? '\r\n' : '\n'
}
});
27 changes: 27 additions & 0 deletions test/parallel/test-os-eol.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const os = require('os');

const eol = common.isWindows ? '\r\n' : '\n';

assert.strictEqual(os.EOL, eol);

common.expectsError(function() {
os.EOL = 123;
}, {
type: TypeError,
message: /^Cannot assign to read only property 'EOL' of object '#<Object>'$/
});

const foo = 'foo';
Object.defineProperties(os, {
EOL: {
configurable: true,
enumerable: true,
writable: false,
value: foo
}
});
assert.strictEqual(os.EOL, foo);

0 comments on commit 6f5087d

Please sign in to comment.