Skip to content

Commit

Permalink
test: rename test-regress-GH-784.js
Browse files Browse the repository at this point in the history
Rename the test appropriately alongside mentioning the subsystem
Also, make a few basic changes to make sure the test conforms
to the standard test structure

Refs: #19105
Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

PR-URL: #19161
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
  • Loading branch information
ryzokuken authored and MylesBorins committed Mar 20, 2018
1 parent c0c6d58 commit 636a5f6
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
// Regression test for GH-784
// https://github.com/joyent/node/issues/784
//
const common = require('../common');

// The test works by making a total of 8 requests to the server. The first
// two are made with the server off - they should come back as ECONNREFUSED.
// The next two are made with server on - they should come back successful.
// The next two are made with the server off - and so on. Without the fix
// we were experiencing parse errors and instead of ECONNREFUSED.
const common = require('../common');
// we were experiencing parse errors instead of ECONNREFUSED.
// https://github.com/nodejs/node-v0.x-archive/issues/784

const http = require('http');
const assert = require('assert');

Expand Down

0 comments on commit 636a5f6

Please sign in to comment.