tools: replace custom assert.fail lint rule

Replace custom lint rule for `assert.fail()` function signature errors with a restricted-syntax rule. PR-URL: #12287 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jul 11, 2017 · 6142747 · 6142747
1 parent d9866ce
commit 6142747
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 31 deletions.
diff --git a/.eslintrc.yaml b/.eslintrc.yaml
@@ -113,6 +113,9 @@ rules:
   }, {
     selector: "ThrowStatement > CallExpression[callee.name=/Error$/]",
     message: "Use new keyword when throwing an Error."
+    }, {
+    selector: "CallExpression[callee.object.name='assert'][callee.property.name='fail'][arguments.length=1]",
+    message: "assert.fail() message should be third argument"
     }]
   no-tabs: 2
   no-trailing-spaces: 2
@@ -143,7 +146,6 @@ rules:
 
   # Custom rules in tools/eslint-rules
   align-multiline-assignment: 2
-  assert-fail-single-argument: 2
   assert-throws-arguments: [2, { requireTwo: false }]
   no-useless-regex-char-class-escape: [2, { override: ['[', ']'] }]
 

diff --git a/tools/eslint-rules/assert-fail-single-argument.js b/tools/eslint-rules/assert-fail-single-argument.js