test_runner: output errors of suites

PR-URL: #50361 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Oct 26, 2023 · 5fab505 · 5fab505
1 parent 10d51e8
commit 5fab505
Show file tree

Hide file tree

Showing 4 changed files with 584 additions and 2 deletions.
diff --git a/lib/internal/test_runner/reporter/spec.js b/lib/internal/test_runner/reporter/spec.js
@@ -78,11 +78,12 @@ class SpecReporter extends Transform {
     } else if (todo !== undefined) {
       title += ` # ${typeof todo === 'string' && todo.length ? todo : 'TODO'}`;
     }
+    const error = this.#formatError(data.details?.error, indent);
     if (hasChildren) {
       // If this test has had children - it was already reported, so slightly modify the output
-      return `${prefix}${indent}${color}${symbols['arrow:right']}${white}${title}\n`;
+      const err = data.details?.error?.failureType === 'subtestsFailed' ? '' : error;
+      return `${prefix}${indent}${color}${symbols['arrow:right']}${white}${title}\n${err}`;
     }
-    const error = this.#formatError(data.details?.error, indent);
     if (skip !== undefined) {
       color = gray;
       symbol = symbols['hyphen:minus'];

diff --git a/test/fixtures/test-runner/output/hooks_spec_reporter.js b/test/fixtures/test-runner/output/hooks_spec_reporter.js
@@ -0,0 +1,11 @@
+'use strict';
+require('../../../common');
+const fixtures = require('../../../common/fixtures');
+const spawn = require('node:child_process').spawn;
+
+const child = spawn(process.execPath,
+                    ['--no-warnings', '--test-reporter', 'spec', fixtures.path('test-runner/output/hooks.js')],
+                    { stdio: 'pipe' });
+// eslint-disable-next-line no-control-regex
+child.stdout.on('data', (d) => process.stdout.write(d.toString().replace(/[^\x00-\x7F]/g, '').replace(/\u001b\[\d+m/g, '')));
+child.stderr.pipe(process.stderr);