events: remove unreachable code

Commit 8d386ed stopped the Event Emitter implementation from storing arrays containing a single listener. This change left a section of code in removeListener() as unreachable. This commit removes the unreachable code. Refs: #12043 PR-URL: #12501 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Apr 21, 2017 · 58066d1 · 58066d1
1 parent 1159a71
commit 58066d1
Showing 1 changed file with 5 additions and 14 deletions.
diff --git a/lib/events.js b/lib/events.js
@@ -374,22 +374,13 @@ EventEmitter.prototype.removeListener =
         if (position < 0)
           return this;
 
-        if (list.length === 1) {
-          if (--this._eventsCount === 0) {
-            this._events = Object.create(null);
-            return this;
-          } else {
-            delete events[type];
-          }
-        } else if (position === 0) {
+        if (position === 0)
           list.shift();
-          if (list.length === 1)
-            events[type] = list[0];
-        } else {
+        else
           spliceOne(list, position);
-          if (list.length === 1)
-            events[type] = list[0];
-        }
+
+        if (list.length === 1)
+          events[type] = list[0];
 
         if (events.removeListener)
           this.emit('removeListener', type, originalListener || listener);