url: simplify native URL object construction

Co-authored-by: Joyee Cheung <[email protected]> PR-URL: #24495 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Dec 5, 2018 · 540929d · 540929d
1 parent 0d7ee19
commit 540929d
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -1369,11 +1369,6 @@ function toPathIfFileURL(fileURLOrPath) {
   return fileURLToPath(fileURLOrPath);
 }
 
-function NativeURL(ctx) {
-  this[context] = ctx;
-}
-NativeURL.prototype = URL.prototype;
-
 function constructUrl(flags, protocol, username, password,
                       host, port, path, query, fragment) {
   var ctx = new URLContext();
@@ -1386,10 +1381,13 @@ function constructUrl(flags, protocol, username, password,
   ctx.query = query;
   ctx.fragment = fragment;
   ctx.host = host;
-  const url = new NativeURL(ctx);
-  url[searchParams] = new URLSearchParams();
-  url[searchParams][context] = url;
-  initSearchParams(url[searchParams], query);
+
+  const url = Object.create(URL.prototype);
+  url[context] = ctx;
+  const params = new URLSearchParams();
+  url[searchParams] = params;
+  params[context] = url;
+  initSearchParams(params, query);
   return url;
 }
 setURLConstructor(constructUrl);