lib: Use regex to compare error message

To make node engine agnostic, use better comparison method for error message. Lazily populate the `circular reference` error message thrown by `JSON.stringify()` which can be used to compare the error message thrown. PR-URL: #11854 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
nodejs · Mar 22, 2017 · 4eb194a · 4eb194a
1 parent 86d74a2
commit 4eb194a
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -38,14 +38,21 @@ const inspectDefaultOptions = Object.seal({
   breakLength: 60
 });
 
-const CIRCULAR_ERROR_MESSAGE = 'Converting circular structure to JSON';
-
+var CIRCULAR_ERROR_MESSAGE;
 var Debug;
 
 function tryStringify(arg) {
   try {
     return JSON.stringify(arg);
   } catch (err) {
+    // Populate the circular error message lazily
+    if (!CIRCULAR_ERROR_MESSAGE) {
+      try {
+        const a = {}; a.a = a; JSON.stringify(a);
+      } catch (err) {
+        CIRCULAR_ERROR_MESSAGE = err.message;
+      }
+    }
     if (err.name === 'TypeError' && err.message === CIRCULAR_ERROR_MESSAGE)
       return '[Circular]';
     throw err;