fixup! src: use option parser for expose_internals

nodejs · Apr 6, 2017 · 4e22b98 · 4e22b98
1 parent 8675a23
commit 4e22b98
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -3339,6 +3339,8 @@ void SetupProcessObject(Environment* env,
   }
 
   // --expose_internals, --expose-internals
+  // Note that this is not exposed as a process property, it is deleted when
+  // node's javascript bootstrap code runs.
   if (expose_internals) {
     READONLY_PROPERTY(process, "_exposeInternals", True(env->isolate()));
   }

diff --git a/test/parallel/test-internal-modules-expose.js b/test/parallel/test-internal-modules-expose.js
@@ -5,3 +5,4 @@ require('../common');
 const assert = require('assert');
 
 assert.strictEqual(typeof require('internal/freelist').FreeList, 'function');
+assert(!('_exposeInternals' in process), 'no process property is leaked');