Skip to content

Commit

Permalink
test: refactor test-dns-regress-6244.js
Browse files Browse the repository at this point in the history
* Move from parallel to internet because it performs a DNS query
* Provide link to relevant issue in comments
* Remove unnecessary explicit no-op function

PR-URL: #13058
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
  • Loading branch information
Trott authored and addaleax committed May 18, 2017
1 parent 5de722a commit 47e3d00
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@
const common = require('../common');
const dns = require('dns');

// Should not segfault, see #6244.
dns.resolve4('127.0.0.1', common.mustCall(() => { }));
// Should not segfault.
// Ref: https://github.com/nodejs/node-v0.x-archive/issues/6244
dns.resolve4('127.0.0.1', common.mustCall());

0 comments on commit 47e3d00

Please sign in to comment.