lib: replace eval with vm.runInThisContext

PR-URL: #18623 Refs: #18212 (review) Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Feb 21, 2018 · 47dfe29 · 47dfe29
1 parent d1ff8fa
commit 47dfe29
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/internal/v8_prof_processor.js b/lib/internal/v8_prof_processor.js
@@ -1,4 +1,7 @@
-/* eslint-disable strict */
+'use strict';
+
+const vm = require('vm');
+
 const scriptFiles = [
   'internal/v8_prof_polyfill',
   'v8/tools/splaytree',
@@ -30,9 +33,9 @@ if (process.platform === 'darwin') {
   tickArguments.push('--windows');
 }
 tickArguments.push.apply(tickArguments, process.argv.slice(1));
-script = `(function() {
+script = `(function(require) {
   arguments = ${JSON.stringify(tickArguments)};
   function write (s) { process.stdout.write(s) }
   ${script}
-})()`;
-eval(script);
+})`;
+vm.runInThisContext(script)(require);