test: fix incorrect assumptions on uid and gid

Add a invalidArgTypeErrorCount variable to adjust the number of expected errors if the uid and gid options cannot be properly validated. Fixes: #19371 PR-URL: #19554 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shingo Inoue <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
nodejs · Mar 29, 2018 · 42c7402 · 42c7402
1 parent 37db277
commit 42c7402
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/test/parallel/test-child-process-spawnsync-validation-errors.js b/test/parallel/test-child-process-spawnsync-validation-errors.js
@@ -5,13 +5,15 @@ const spawnSync = require('child_process').spawnSync;
 const signals = process.binding('constants').os.signals;
 
 let invalidArgTypeError;
+let invalidArgTypeErrorCount = 62;
 
 if (common.isWindows) {
   invalidArgTypeError =
     common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 42);
 } else {
   invalidArgTypeError =
-    common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError }, 62);
+    common.expectsError({ code: 'ERR_INVALID_ARG_TYPE', type: TypeError },
+                        invalidArgTypeErrorCount);
 }
 
 const invalidRangeError =
@@ -76,6 +78,9 @@ if (!common.isWindows) {
       fail('uid', Infinity, invalidArgTypeError);
       fail('uid', 3.1, invalidArgTypeError);
       fail('uid', -3.1, invalidArgTypeError);
+    } else {
+      //Decrement invalidArgTypeErrorCount if validation isn't possible
+      invalidArgTypeErrorCount -= 10;
     }
   }
 
@@ -95,6 +100,9 @@ if (!common.isWindows) {
       fail('gid', Infinity, invalidArgTypeError);
       fail('gid', 3.1, invalidArgTypeError);
       fail('gid', -3.1, invalidArgTypeError);
+    } else {
+      //Decrement invalidArgTypeErrorCount if validation isn't possible
+      invalidArgTypeErrorCount -= 10;
     }
   }
 }