test: http2 client settings invalid callback

PR-URL: #18850 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs · Aug 7, 2018 · 4279c1e · 4279c1e
1 parent d5b60d8
commit 4279c1e
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/test/parallel/test-http2-client-settings-before-connect.js b/test/parallel/test-http2-client-settings-before-connect.js
@@ -35,13 +35,26 @@ server.listen(0, common.mustCall(() => {
     ['enablePush', 0, TypeError],
     ['enablePush', null, TypeError],
     ['enablePush', {}, TypeError]
-  ].forEach((i) => {
+  ].forEach(([name, value, errorType]) =>
     common.expectsError(
-      () => client.settings({ [i[0]]: i[1] }),
+      () => client.settings({ [name]: value }),
       {
         code: 'ERR_HTTP2_INVALID_SETTING_VALUE',
-        type: i[2] });
-  });
+        type: errorType
+      }
+    )
+  );
+
+  [1, true, {}, []].forEach((invalidCallback) =>
+    common.expectsError(
+      () => client.settings({}, invalidCallback),
+      {
+        type: TypeError,
+        code: 'ERR_INVALID_CALLBACK',
+        message: 'callback must be a function'
+      }
+    )
+  );
 
   client.settings({ maxFrameSize: 1234567 });