test: fix freebsd10-64 CI failures

Remove unneeded timers from some tests and move others from parallel
testing to sequential testing.

This is to resolve test failures on freebsd10-64 on CI. The failures
are all due to timers firing later than expected. Timers firing later
than they are set for can happen on resource-constrained hosts and is
not a bug.

In general, it may be wise to put tests that depend on timing into
sequential testing rather than parallel testing, as the timing can
be affected by other simultaneously-running test processes.

Fixes: #8041
Fixes: #9227
PR-URL: #9317
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Julien Gilli <[email protected]>
Reviewed-By: Johan Bergstrom <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>

test/parallel/test-dgram-send-callback-multi-buffer.js

@@ -6,13 +6,8 @@ const dgram = require('dgram');
 
 const client = dgram.createSocket('udp4');
 
-const timer = setTimeout(function() {
-  throw new Error('Timeout');
-}, common.platformTimeout(200));
-
 const messageSent = common.mustCall(function messageSent(err, bytes) {
   assert.equal(bytes, buf1.length + buf2.length);
-  clearTimeout(timer);
 });
 
 const buf1 = Buffer.alloc(256, 'x');

test/parallel/test-dgram-send-multi-buffer-copy.js

@@ -6,13 +6,8 @@ const dgram = require('dgram');
 
 const client = dgram.createSocket('udp4');
 
-const timer = setTimeout(function() {
-  throw new Error('Timeout');
-}, common.platformTimeout(200));
-
 const onMessage = common.mustCall(function(err, bytes) {
   assert.equal(bytes, buf1.length + buf2.length);
-  clearTimeout(timer);
 });
 
 const buf1 = Buffer.alloc(256, 'x');

test/parallel/test-tls-server-failed-handshake-emits-clienterror.js

@@ -11,27 +11,19 @@ const assert = require('assert');
 
 const bonkers = Buffer.alloc(1024, 42);
 
-let tlsClientErrorEmited = false;
 
 const server = tls.createServer({})
   .listen(0, function() {
     const c = net.connect({ port: this.address().port }, function() {
       c.write(bonkers);
     });
 
-  }).on('tlsClientError', function(e) {
-    tlsClientErrorEmited = true;
+  }).on('tlsClientError', common.mustCall(function(e) {
     assert.ok(e instanceof Error,
               'Instance of Error should be passed to error handler');
     assert.ok(e.message.match(
       /SSL routines:SSL23_GET_CLIENT_HELLO:unknown protocol/),
       'Expecting SSL unknown protocol');
-  });
 
-setTimeout(function() {
-  server.close();
-
-  assert.ok(tlsClientErrorEmited,
-            'tlsClientError should be emited');
-
-}, common.platformTimeout(200));
+    server.close();
+  }));