Skip to content

Commit

Permalink
quic: address feedback comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jasnell committed Mar 30, 2023
1 parent 265a245 commit 3bb8924
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/quic/sessionticket.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ using v8::ValueSerializer;
namespace quic {

namespace {
std::optional<SessionTicket::AppData::Source*> get_appdatasource(SSL* ssl) {
std::optional<SessionTicket::AppData::Source*> GetAppDataSource(SSL* ssl) {
ngtcp2_crypto_conn_ref* ref =
static_cast<ngtcp2_crypto_conn_ref*>(SSL_get_app_data(ssl));
if (ref != nullptr && ref->user_data != nullptr) {
Expand Down Expand Up @@ -155,15 +155,15 @@ std::optional<const uv_buf_t> SessionTicket::AppData::Get() const {
}

void SessionTicket::AppData::Collect(SSL* ssl) {
auto source = get_appdatasource(ssl);
auto source = GetAppDataSource(ssl);
if (source.has_value()) {
SessionTicket::AppData app_data(ssl);
source.value()->CollectSessionTicketAppData(&app_data);
}
}

SessionTicket::AppData::Status SessionTicket::AppData::Extract(SSL* ssl) {
auto source = get_appdatasource(ssl);
auto source = GetAppDataSource(ssl);
if (source.has_value()) {
SessionTicket::AppData app_data(ssl);
return source.value()->ExtractSessionTicketAppData(app_data);
Expand Down

0 comments on commit 3bb8924

Please sign in to comment.