fs: don't hard code name in validatePosition()

The name of the position being validated by validatePosition() was not being used. Instead, the string 'position' was being used everywhere. It worked out because the only call sites were using the name 'position' as well. PR-URL: #44767 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
nodejs · Oct 7, 2022 · 3aa590b · 3aa590b
1 parent 07dadb4
commit 3aa590b
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/lib/internal/fs/utils.js b/lib/internal/fs/utils.js
@@ -906,17 +906,15 @@ const validatePrimitiveStringAfterArrayBufferView = hideStackFrames((buffer, nam
 
 const validatePosition = hideStackFrames((position, name) => {
   if (typeof position === 'number') {
-    validateInteger(position, 'position');
+    validateInteger(position, name);
   } else if (typeof position === 'bigint') {
     if (!(position >= -(2n ** 63n) && position <= 2n ** 63n - 1n)) {
-      throw new ERR_OUT_OF_RANGE('position',
+      throw new ERR_OUT_OF_RANGE(name,
                                  `>= ${-(2n ** 63n)} && <= ${2n ** 63n - 1n}`,
                                  position);
     }
   } else {
-    throw new ERR_INVALID_ARG_TYPE('position',
-                                   ['integer', 'bigint'],
-                                   position);
+    throw new ERR_INVALID_ARG_TYPE(name, ['integer', 'bigint'], position);
   }
 });