benchmark: fix build warnings

The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <[email protected]> PR-URL: #36157 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]>
nodejs · Nov 20, 2020 · 39e4d82 · 39e4d82
1 parent efbec85
commit 39e4d82
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/benchmark/napi/function_args/binding.cc b/benchmark/napi/function_args/binding.cc
@@ -123,7 +123,9 @@ void CallWithArguments(const FunctionCallbackInfo<Value>& args) {
   }
 }
 
-void Initialize(Local<Object> target) {
+void Initialize(Local<Object> target,
+                Local<Value> module,
+                void* data) {
   NODE_SET_METHOD(target, "callWithString", CallWithString);
   NODE_SET_METHOD(target, "callWithLongString", CallWithString);
 

diff --git a/benchmark/napi/function_call/binding.cc b/benchmark/napi/function_call/binding.cc
@@ -7,7 +7,9 @@ void Hello(const v8::FunctionCallbackInfo<v8::Value>& args) {
   args.GetReturnValue().Set(c++);
 }
 
-void Initialize(v8::Local<v8::Object> target) {
+void Initialize(v8::Local<v8::Object> target,
+                v8::Local<v8::Value> module,
+                void* data) {
   NODE_SET_METHOD(target, "hello", Hello);
 }