events: define event handler as enumerable

PR-URL: #35931 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Nov 9, 2020 · 33e2ee5 · 33e2ee5
1 parent 7a2edea
commit 33e2ee5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -592,7 +592,9 @@ function defineEventHandler(emitter, name) {
         emitter.addEventListener(name, value);
       }
       eventHandlerValue = value;
-    }
+    },
+    configurable: true,
+    enumerable: true
   });
 }
 module.exports = {

diff --git a/test/parallel/test-eventtarget.js b/test/parallel/test-eventtarget.js
@@ -517,3 +517,10 @@ let asyncTest = Promise.resolve();
   }));
   target.dispatchEvent(new Event('foo'));
 }
+{
+  const target = new EventTarget();
+  defineEventHandler(target, 'foo');
+  const descriptor = Object.getOwnPropertyDescriptor(target, 'onfoo');
+  strictEqual(descriptor.configurable, true);
+  strictEqual(descriptor.enumerable, true);
+}