lib: fix consistency of methods that emit warnings

PR-URL: #41249 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mestery <[email protected]>
nodejs · Jan 24, 2022 · 306dd1c · 306dd1c
1 parent 09763a2
commit 306dd1c
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/lib/internal/dns/utils.js b/lib/internal/dns/utils.js
@@ -178,18 +178,16 @@ function validateHints(hints) {
 }
 
 let invalidHostnameWarningEmitted = false;
-
 function emitInvalidHostnameWarning(hostname) {
-  if (invalidHostnameWarningEmitted) {
-    return;
+  if (!invalidHostnameWarningEmitted) {
+    process.emitWarning(
+      `The provided hostname "${hostname}" is not a valid ` +
+      'hostname, and is supported in the dns module solely for compatibility.',
+      'DeprecationWarning',
+      'DEP0118'
+    );
+    invalidHostnameWarningEmitted = true;
   }
-  invalidHostnameWarningEmitted = true;
-  process.emitWarning(
-    `The provided hostname "${hostname}" is not a valid ` +
-    'hostname, and is supported in the dns module solely for compatibility.',
-    'DeprecationWarning',
-    'DEP0118'
-  );
 }
 
 let typeCoercionWarningEmitted = false;