events: use Reflect.apply

Instead of callback bound apply, instead use the standard Reflect.apply. This is both safer and appears to offer a slight performance benefit. Backport-PR-URL: #18487 PR-URL: #17456 Refs: #12956 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
nodejs · Feb 20, 2018 · 28edc1d · 28edc1d
1 parent 3ae5cf2
commit 28edc1d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/domain.js b/lib/domain.js
@@ -400,7 +400,7 @@ const eventEmit = EventEmitter.prototype.emit;
 EventEmitter.prototype.emit = function emit(...args) {
   const domain = this.domain;
   if (domain === null || domain === undefined || this === process) {
-    return eventEmit.apply(this, args);
+    return Reflect.apply(eventEmit, this, args);
   }
 
   const type = args[0];
@@ -415,7 +415,7 @@ EventEmitter.prototype.emit = function emit(...args) {
 
   domain.enter();
   try {
-    return eventEmit.apply(this, args);
+    return Reflect.apply(eventEmit, this, args);
   } catch (er) {
     if (typeof er === 'object' && er !== null) {
       er.domainEmitter = this;

diff --git a/lib/events.js b/lib/events.js
@@ -124,12 +124,12 @@ EventEmitter.prototype.emit = function emit(type, ...args) {
     return false;
 
   if (typeof handler === 'function') {
-    handler.apply(this, args);
+    Reflect.apply(handler, this, args);
   } else {
     const len = handler.length;
     const listeners = arrayClone(handler, len);
     for (var i = 0; i < len; ++i)
-      listeners[i].apply(this, args);
+      Reflect.apply(listeners[i], this, args);
   }
 
   return true;
@@ -216,7 +216,7 @@ function onceWrapper(...args) {
   if (!this.fired) {
     this.target.removeListener(this.type, this.wrapFn);
     this.fired = true;
-    this.listener.apply(this.target, args);
+    Reflect.apply(this.listener, this.target, args);
   }
 }