src: check for overflow when extending AliasedBufferBase

When resizing an aliased_buffer check if the new size will overflow. PR-URL: #31740 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Apr 22, 2020 · 28cfaa8 · 28cfaa8
1 parent afc0c70
commit 28cfaa8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/aliased_buffer.h b/src/aliased_buffer.h
@@ -221,7 +221,8 @@ class AliasedBufferBase {
     const v8::HandleScope handle_scope(isolate_);
 
     const size_t old_size_in_bytes = sizeof(NativeT) * count_;
-    const size_t new_size_in_bytes = sizeof(NativeT) * new_capacity;
+    const size_t new_size_in_bytes = MultiplyWithOverflowCheck(sizeof(NativeT),
+                                                              new_capacity);
 
     // allocate v8 new ArrayBuffer
     v8::Local<v8::ArrayBuffer> ab = v8::ArrayBuffer::New(