timers: avoid generating holey internal arrays

PR-URL: #54771 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs · Sep 10, 2024 · 26b03c1 · 26b03c1
1 parent 741004a
commit 26b03c1
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/timers.js b/lib/timers.js
@@ -22,6 +22,7 @@
 'use strict';
 
 const {
+  ArrayPrototypePush,
   MathTrunc,
   ObjectDefineProperties,
   ObjectDefineProperty,
@@ -154,7 +155,7 @@ function setTimeout(callback, after, arg1, arg2, arg3) {
       args = [arg1, arg2, arg3];
       for (i = 5; i < arguments.length; i++) {
         // Extend array dynamically, makes .apply run much faster in v6.0.0
-        args[i - 2] = arguments[i];
+        ArrayPrototypePush(args, arguments[i]);
       }
       break;
   }
@@ -224,7 +225,7 @@ function setInterval(callback, repeat, arg1, arg2, arg3) {
       args = [arg1, arg2, arg3];
       for (i = 5; i < arguments.length; i++) {
         // Extend array dynamically, makes .apply run much faster in v6.0.0
-        args[i - 2] = arguments[i];
+        ArrayPrototypePush(args, arguments[i]);
       }
       break;
   }
@@ -296,7 +297,7 @@ function setImmediate(callback, arg1, arg2, arg3) {
       args = [arg1, arg2, arg3];
       for (i = 4; i < arguments.length; i++) {
         // Extend array dynamically, makes .apply run much faster in v6.0.0
-        args[i - 1] = arguments[i];
+        ArrayPrototypePush(args, arguments[i]);
       }
       break;
   }