vm: refactor to use validate function

Throwing error after checking type is repeated. So replace it with validate function. PR-URL: #46176 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Jan 26, 2023 · 24f2aae · 24f2aae
1 parent f7a4cce
commit 24f2aae
Showing 1 changed file with 7 additions and 16 deletions.
diff --git a/lib/internal/vm/module.js b/lib/internal/vm/module.js
@@ -21,7 +21,6 @@ const {
 const { isContext } = internalBinding('contextify');
 const {
   isModuleNamespaceObject,
-  isArrayBufferView,
 } = require('internal/util/types');
 const {
   customInspectSymbol,
@@ -41,6 +40,7 @@ const {
 } = require('internal/errors').codes;
 const {
   validateBoolean,
+  validateBuffer,
   validateFunction,
   validateInt32,
   validateObject,
@@ -276,25 +276,16 @@ class SourceTextModule extends Module {
     validateInt32(lineOffset, 'options.lineOffset');
     validateInt32(columnOffset, 'options.columnOffset');
 
-    if (initializeImportMeta !== undefined &&
-        typeof initializeImportMeta !== 'function') {
-      throw new ERR_INVALID_ARG_TYPE(
-        'options.initializeImportMeta', 'function', initializeImportMeta);
+    if (initializeImportMeta !== undefined) {
+      validateFunction(initializeImportMeta, 'options.initializeImportMeta');
     }
 
-    if (importModuleDynamically !== undefined &&
-        typeof importModuleDynamically !== 'function') {
-      throw new ERR_INVALID_ARG_TYPE(
-        'options.importModuleDynamically', 'function',
-        importModuleDynamically);
+    if (importModuleDynamically !== undefined) {
+      validateFunction(importModuleDynamically, 'options.importModuleDynamically');
     }
 
-    if (cachedData !== undefined && !isArrayBufferView(cachedData)) {
-      throw new ERR_INVALID_ARG_TYPE(
-        'options.cachedData',
-        ['Buffer', 'TypedArray', 'DataView'],
-        cachedData
-      );
+    if (cachedData !== undefined) {
+      validateBuffer(cachedData, 'options.cachedData');
     }
 
     super({